-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1610 unexpected field-error related to a well-formatted value example of a schema's boolean field using frictionless validate #1615
Fix #1610 unexpected field-error related to a well-formatted value example of a schema's boolean field using frictionless validate #1615
Conversation
Thanks @amelie-rondot! Can you please fix the lining error? |
@roll thanks a lot for reviewing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added a few comments
Thanks @roll for reviewing! I've committed updates. |
The change requested have been taken into account and the PR is ready for review ! I noticed some linting errors that seem unrelated to this review, and that I corrected in the other PR (should I have ?). I haven't corrected them in this one as it would mostly lead to merge conflicts. Tell me if you prefer me to do something about it. |
I merged the main branch, this PR is ready as well ! |
@pierrecamilleri I just merged #1674 . Could you please rebase and then merge when test are passing? |
…r to use default true values and default false values
…d 'falseValues' in a schema descriptor
… use default true values and default false values
…d cell: tests pass
…zed trueValues or falseValues properties in schema descriptor
…o validate 'example' value from descriptor boolean field
`from_descriptor` leads to a `RecursionError`
0ea8865
to
42b14fa
Compare
This PR fixes the
field-error
which occured doingfrictionless validate data.csv --schema schema.json
with aTableSchema
schema
containing aBooleanField
customised with 'trueValues' or 'falseValues' and 'example' value , for example:This PR add tests cases to ensure that example value is correctly evaluated according to customized 'trueValues' or 'falseValues', as expected.