Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply character relic sets to the relic tab filter bar #710

Closed
wants to merge 3 commits into from

Conversation

WolfBungalow
Copy link
Contributor

@WolfBungalow WolfBungalow commented Nov 11, 2024

Pull Request

Description

  • Added 'Select relics' button to RelicsTab. This button filters relics based on the Recommended Character's relic and ornament sets as defined in the Character Optimizer tab.

Related Issue

Checklist

  • I have added commit messages that are descriptive and meaningful.
  • I have tested the changes locally.
  • I have reviewed the code changes.

Screenshots

image

@WolfBungalow
Copy link
Contributor Author

Implemented @FI00ds change.

@fribbels
Copy link
Owner

I'm not sure I agree with pulling relics based on the optimizer page, most of the characters are just going to be empty sets since people tend to not choose set filters - This kinda overlaps with: #247

The ideal workflow should be that we predefine a set of [high / med / low] value relics sets per character and let the user choose a preset that way. The difficulty is just creating and maintaining that relic mapping across 60 characters x 40 sets

@WolfBungalow
Copy link
Contributor Author

I agree that maintaining optimal sets for all the characters would be a great burden and I would leave that to groups like prydwen or r/mains that already do.

This button is simply a feature to quickly copy the work a user has already chosen to do on the character optimizer tab over the relics tab. If they don’t use the provided tool, that’s up to them.

To quote ChatGPT, “the feature empowers users to customize their experience according to their knowledge or preference, rather than imposing a system that might not fit all playstyles or the meta at any given time.” That’s basically what Fribbels Optimizer does.

For my personal use, with about 10-15 characters I care about, I reference prydwen and fill out the sets section on the character tab. Then when I go looking for relics to upgrade, I end up having to duplicate my work and manually click all the relics I have already setup on the character page.

It’s a feature I offered because it would be useful to me, and I suspect others as well.

What I would add to it would be a "?" icon or tooltip explaining the button purpose and gray the button out if the recommended character didn't have any sets selected on the character tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants