Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #190

wants to merge 1 commit into from

Conversation

TommyZihao
Copy link

Add Chinese video and jupyter notebook tutorials

What does this PR do?

Closes # (issue)

Before submitting

  • Was this discussed/approved in a Github issue or a discussion? Please add a link to it if that's the case.
  • You have read the contribution guidelines and followed them in this PR.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Add Chinese video and jupyter notebook tutorials
@frgfm
Copy link
Owner

frgfm commented Sep 25, 2022

Hi @TommyZihao 👋

Thanks for opening the PR and producing this content!
Quick note on the PR though:

  • ideally, many other languages will become supported. I have to think about a maintainable structure for documentation and content across languages
  • I, for one, speak English, among others, but not Chinese. So I have no way to validate the content

If you have suggestions, I'm all ears but so far, what I've seen is in FastAPI, where Sebastian has a large community and started gradually integrating multiple languages in its documentation. Follow his example, it might be possible to go for:

  • having Chinese as an available language for the documentation
  • having Chinese versions of the notebook tutorials

But having different sources of content in a language I can't speak is hard to validate/maintain for me :/

What do you think?

@frgfm frgfm self-assigned this Sep 29, 2022
@frgfm frgfm added topic: docs Improvements or additions to documentation type: improvement New feature or request awaiting response labels Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response topic: docs Improvements or additions to documentation type: improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants