Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add domain_code fallback #2

Closed
wants to merge 2 commits into from
Closed

add domain_code fallback #2

wants to merge 2 commits into from

Conversation

T0biii
Copy link
Member

@T0biii T0biii commented Jul 26, 2023

add domain_code "ffmuc_uisp_respondd_fallback"
there is no domain, or?

grische
grische suggested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@T0biii I think this PR is not sufficient for it to work. I added a new PR #3 that addresses these as I had no push rights on your repo

uisp_respondd/uisp_client.py
@@ -28,6 +28,7 @@ class Accesspoint:
latitude: float
longitude: float
neighbour: str
domain_code: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT there some changes in respondd_client.py missing.

@T0biii
Copy link
Member Author

T0biii commented Jan 3, 2024

see #3

@T0biii T0biii closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grische grische grische requested changes

@GoliathLabs GoliathLabs GoliathLabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T0biii @grische @GoliathLabs