build: extend GLUON_DEBUG with values 0, 1 and 2 #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugging binaries in images that are built with sstrip is extremely annoying, as not even objdump will work on them. Switching from sstrip to standard strip increases the ath79 image size (for some usual Archer C7 v2 configuration I used for testing) by ~70KiB, or 1.3% of the rootfs size (~1% of the total image size), which is rarely worth the decreased debuggability. Extend GLUON_DEBUG to not only distinguish 0 and 1, such that: - 0 uses sstrip same as before - 1 switches to regular strip; this is the new default - 2 includes all debug info, like GLUON_DEBUG=1 did before
Unlike Markdown, RST uses double backticks for monospace text; single backticks result in italic text. Use monospace for commands like the surrounding paragraphs.
neocturne
added
0. type: enhancement
github-actions
bot
added
3. topic: docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging binaries in images that are built with sstrip is extremely
annoying, as not even objdump will work on them.
Switching from sstrip to standard strip increases the ath79 image size
(for some usual Archer C7 v2 configuration I used for testing) by ~70KiB,
or 1.3% of the rootfs size (~1% of the total image size), which is
rarely worth the decreased debuggability.
Extend GLUON_DEBUG to not only distinguish 0 and 1, such that: