-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gluon-ebtables-limit-arp: stop for autoupdater #3162
gluon-ebtables-limit-arp: stop for autoupdater #3162
Conversation
Stop and start the gluon-arp-limiter service before the network is brought down when commencing update. Start the service after the network is brought back up when aborting. Signed-off-by: David Bauer <[email protected]>
can you add the reason for the change? |
We are currently investigating cases where the autoupdater would start the sysupgrade procedure which never finishes. The node is in a state with stopped network, firmware placed in In this state, the arp-limiter is spamming the log, complaining about a missing bat0 interface, rotating away potential informations about the reason for the failing autoupdater process. |
This comment was marked as off-topic.
This comment was marked as off-topic.
No, this is a different problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gluon-arp-limiter does not have a proper shutdown procedure / signal handler right now. So the ebtables rules it has added will stay even after its shutdown. However when gluon-arp-limit is then started again through abort.d, it will flush the according two tables during its initalization, before adding its stuff again. So generally looks fine to me, as long as it's shutdowned stated does not stay for too long.
Also: Tested these two, added scripts on a Plasmacloud PA2200. ebtables rules look fine to me afterwards.
Stop and start the gluon-arp-limiter service before the network is brought down when commencing update. Start the service after the network is brought back up when aborting. Signed-off-by: David Bauer <[email protected]>
Stop and start the gluon-arp-limiter service before the network is brought down when commencing update.
Start the service after the network is brought back up when aborting.