Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-ebtables-limit-arp: stop for autoupdater #3162

Merged

Conversation

blocktrron
Copy link
Member

Stop and start the gluon-arp-limiter service before the network is brought down when commencing update.

Start the service after the network is brought back up when aborting.

Stop and start the gluon-arp-limiter service before the network is
brought down when commencing update.

Start the service after the network is brought back up when aborting.

Signed-off-by: David Bauer <[email protected]>
@rotanid
Copy link
Member

rotanid commented Jan 18, 2024

can you add the reason for the change?

@blocktrron
Copy link
Member Author

We are currently investigating cases where the autoupdater would start the sysupgrade procedure which never finishes.

The node is in a state with stopped network, firmware placed in /tmp but no updater running.

In this state, the arp-limiter is spamming the log, complaining about a missing bat0 interface, rotating away potential informations about the reason for the failing autoupdater process.

@maurerle

This comment was marked as off-topic.

@blocktrron
Copy link
Member Author

No, this is a different problem.

@T-X T-X self-requested a review January 29, 2024 01:24
Copy link
Contributor

@T-X T-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gluon-arp-limiter does not have a proper shutdown procedure / signal handler right now. So the ebtables rules it has added will stay even after its shutdown. However when gluon-arp-limit is then started again through abort.d, it will flush the according two tables during its initalization, before adding its stuff again. So generally looks fine to me, as long as it's shutdowned stated does not stay for too long.

Also: Tested these two, added scripts on a Plasmacloud PA2200. ebtables rules look fine to me afterwards.

@blocktrron blocktrron merged commit 0bbe55c into freifunk-gluon:master Mar 5, 2024
9 checks passed
misanthropos pushed a commit to misanthropos/gluon that referenced this pull request Apr 29, 2024
Stop and start the gluon-arp-limiter service before the network is
brought down when commencing update.

Start the service after the network is brought back up when aborting.

Signed-off-by: David Bauer <[email protected]>
Djfe added a commit to Djfe/gluon that referenced this pull request Oct 31, 2024
Djfe added a commit to Djfe/gluon that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants