Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips-mt76x8: add support for TP-Link Archer C50 v6 #3004

Closed
wants to merge 4 commits into from
Closed

ramips-mt76x8: add support for TP-Link Archer C50 v6 #3004

wants to merge 4 commits into from

Conversation

GoliathLabs
Copy link
Contributor

  • Must be flashable from vendor firmware
    • Web interface
    • TFTP
    • Other:
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • On devices supplied via PoE, there is usually no explicit WAN/LAN labeling on the hardware.
        The PoE input should be the WAN port in this case.
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Sep 29, 2023
@GoliathLabs
Copy link
Contributor Author

The upstream PR has to be merged first: openwrt/openwrt#13547

PR has been tested properly with FFMUC

@herbetom
Copy link
Contributor

herbetom commented Sep 29, 2023

I would suggest marking this PR a draft until a Review makes sense.

@rotanid rotanid marked this pull request as draft October 2, 2023 00:10
@blocktrron
Copy link
Member

@GoliathLabs Please verify the request hauke stated in openwrt/openwrt#13547 (comment) - If the 5GHz radio does not show the stated issue, I'd merge this PR upstream and you can create a backport.

@blocktrron blocktrron added the 2. status: waiting-on-author Waiting on some action from the author label Nov 2, 2023
@GoliathLabs
Copy link
Contributor Author

I no longer have the device. I did the testing for another party. I'll try to get our firmware built to get it tested out properly

@GoliathLabs
Copy link
Contributor Author

Upstream has been merged. This can now be merged

@GoliathLabs GoliathLabs marked this pull request as ready for review November 27, 2023 21:43
@rotanid
Copy link
Member

rotanid commented Nov 27, 2023

@GoliathLabs it has to be in the 23.05 branch of OpenWrt

@rotanid rotanid added the 2. status: waiting-on-upstream Waiting for upstream changes label Nov 27, 2023
@blocktrron
Copy link
Member

@rotanid I'd be for closing this PR, as the device testing does not seem to be conducted using any state present in upstream nor this PR.

This is until the device is backported upstream and re-tested with the respective upstream state.

@GoliathLabs
Copy link
Contributor Author

@blocktrron you could also just talk to me directly and properly communicate, what would be necessary for this PR to get merged instead of closing it?

@blocktrron
Copy link
Member

blocktrron commented Nov 28, 2023

@GoliathLabs All communication regarding this PR is in this very PR, so please explain where i did not communicate correctly or left you out of the discussion?

I've outlined the requirements in the last sentence of my last comment.

This is until the device is backported upstream and re-tested with the respective upstream state.

I've mentioned the need of a backport here: #3004 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: waiting-on-author Waiting on some action from the author 2. status: waiting-on-upstream Waiting for upstream changes 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants