gluon-status-page: modernize html #2960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move `script` to `head` * Add waring if JavaScript support is missing * Change some tags to semantic html for better accessibility * Add link if user has automatic redirect disabled * Remove outdated `meta`-tags from redirect * Update outdated node-sass to dart-sass
github-actions
bot
added
3. topic: package
maurerle
approved these changes
Sep 10, 2023
neocturne
reviewed
Sep 10, 2023
| <head> | ||
| <meta http-equiv="Cache-Control" content="no-cache, no-store, must-revalidate"> | ||
| <meta http-equiv="Pragma" content="no-cache"> | ||
| <meta http-equiv="Expires" content="0"> |
There was a problem hiding this comment.
What is the replacement for these tags, if we want to prevent caching of the redirect?
| </head> | ||
| <body> | ||
| Redirect to <a href="/cgi-bin/status">/cgi-bin/status</a> |
There was a problem hiding this comment.
I think showing such a link for a moment is very ugly, I'd rather leave the body empty.
|
@Rotzbua Do you still have plans for addressing the suggestions? |
|
closing due to lack of reaction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
scripttoheadmeta-tags from redirectReference
Mentioned in #2953