-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib: Dockerfile: actually create gluon user directory #2838
Conversation
I assume this is already handled by the VOLUME? I don't think it makes much sense to copy the skel files into a directory that is mounted over anyways. |
@skorpy2009 is there a problem you intend to solve with this measure? |
@NeoRaider @AiyionPrime currently if you use this container and want to do anything with the user, for example you need git config it breaks because there is no gluon folder |
The Gluon build directory is supposed to be mounted into the container at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For gluons build process this PR does not do any good.
The argument is, for others to reuse the Dockerfile as dependency installer without actually using the rest of the Dockerfile (e.g. the mount) this directory must still not be empty.
As this file lies in contrib, we could support it, if somebody verifies it does not break anything for us.
The commit message should mention as well, why this is a good idea, even though it's not necessary for gluon (to prevent the next person to optimize it out again)
It is unclear to me if the behaviors of Docker and Podman differ here (I only have Podman on my system), but Podman creates an empty volume and mounts it to So an explanation in what situation it is even possible to end up with no That being said, I looked at the Dockerfile reference again and found that the contents under the directory specified as a |
Fixed by #2975 |
No description provided.