Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove remaining CSS workaround #2737

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

neocturne
Copy link
Member

@neocturne neocturne commented Dec 27, 2022

Remove a workaround for a CSS issue in older Firefox versions, which was recently fixed (at some point between Firefox 102 and 108). Firefox 108+ now displays the bullet points at the right vertical position even without the hack in [1].

[1] https://gluon.readthedocs.io/en/latest/releases/v2018.1.html#site-conf

Opening as a draft for now, as the current Extended Support Release is Firefox 102. I propose to merge this as soon as all Firefox versions without the fix are EOL.

@github-actions github-actions bot added the 3. topic: docs Topic: Documentation label Dec 27, 2022
@AiyionPrime
Copy link
Member

So if the fix does not make it into an upcoming point version of 102.x ESR,
the latest this will be merged is the 26th September this year, when 102 goes EOL and 115 will be the only supported ESR? [1]

The next ESR release dates are 17th of this month (102.7), and 14th February (102.8);
the later being the one likely to include this fix.

[1] https://wiki.mozilla.org/Release_Management/Calendar

@AiyionPrime AiyionPrime added the 2. status: waiting-on-upstream Waiting for upstream changes label Jan 10, 2023
Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 104 to 107 in docs/conf.py should be gone as well, as this is effectively the last artifact of #2078, right?

96f1547#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3R104-R107

@neocturne
Copy link
Member Author

Line 104 to 107 in docs/conf.py should be gone as well, as this is effectively the last artifact of #2078, right?

96f1547#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3R104-R107

Fixed

Remove a workaround for a CSS issue in older Firefox versions, which was
recently fixed (at some point between Firefox 102 and 108). Firefox 108+
now displays the bullet points at the right vertical position even without
the hack in [1].

[1] https://gluon.readthedocs.io/en/latest/releases/v2018.1.html#site-conf
@neocturne neocturne marked this pull request as ready for review September 27, 2023 21:30
@neocturne
Copy link
Member Author

Current Firefox ESR is 115.x, so we can finally merge this.

@neocturne neocturne added 2. status: waiting-on-review Awaiting review from the assignee but also interested parties. and removed 2. status: waiting-on-upstream Waiting for upstream changes labels Sep 27, 2023
@blocktrron blocktrron merged commit 5f6dbe6 into master Sep 28, 2023
18 checks passed
@neocturne neocturne deleted the doc-remove-css-hack branch September 28, 2023 15:30
hafu pushed a commit to Freifunk-Potsdam/gluon that referenced this pull request Jun 2, 2024
Remove a workaround for a CSS issue in older Firefox versions, which was
recently fixed (at some point between Firefox 102 and 108). Firefox 108+
now displays the bullet points at the right vertical position even without
the hack in [1].

[1] https://gluon.readthedocs.io/en/latest/releases/v2018.1.html#site-conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: waiting-on-review Awaiting review from the assignee but also interested parties. 3. topic: docs Topic: Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants