-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Graz to census #27
base: master
Are you sure you want to change the base?
Conversation
Wondering why the actions aren't running here. |
I rebased, that didn't fix it either. It's in a different repository, maybe that makes a difference? |
Actions were disabled on the fork, I enabled them. Still I don't see them being ran. |
You may want to make another copy of the workflow that is not scheudled because github appears to handle it stupidly |
I've got it running in the fork: https://github.com/ffgraz/census-exporter/actions/runs/4972195685/jobs/8897240635 |
Hrm so there's no Graz in the output Our version numbers look like this: gluon-v2021.1-997-g2cfcbe1 Might that be the issue? |
Ok so the issue is that one of the nodeid fields is null (something wrong with our data). I made it so the broken value is ignored and exceptions are printed instead of silently ignored. New CI: https://github.com/ffgraz/census-exporter/actions/runs/4974688289
It adds the non-gluon nodes (this is a boardid from https://git.mkg20001.io/mkg20001/respondd.sh from openwrt 8 - congrats to our age old infrastructure) We also have:
(you know the joke about temporary things. this isn't gluon, this is a random server. with some hacks it's running respondd - offtopic, i could publish a flake with respondd nixpkg + patches for server usage) |
I am in favor of merging this so that the gluon nodes from the ffgraz community are also taken into account |
Is there anything left for me to do on this PR? (The nodes may appear offline until end of month for a bit, because we're moving infrastructure arround) |
I'm in favor of merging as well, Graz contributed to freifunk gluon in the past and likely in the future as well. Are there any technical reasons not to merge left? |
I'm currently getting a timeout from this:
But I would otherwise also love to see this merged. (And I tested these changes, they don't seem to otherwise break anything, as far as I can tell. And look fine to me.) |
We've got non-gluon nodes in our hopglass aswell (https://hopglass.ffgraz.net). You could just ignore those, they don't have any version that matches the gluon pattern.
Also do you prefer meshviewer.json or nodes.json? We've got both.
Note that graz is part of funkfeuer - which has similar goals as freifunk - and is in austria. We're currently giving out neighbours in batman-compatible format.