feat: Upgrade OpenAPI to R17 #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @pf-lin ,
Please note that the content type of the response will be "multipart/related" if and only if the message has binary body part(s). Otherwise, the content type should be "application/json". |
|
Also, This issue has already been fixed, please refer to the last two commits in openapi PR: |
andy89923
reviewed
Sep 4, 2024
TYuan0816
approved these changes
Sep 10, 2024
andy89923
reviewed
Sep 12, 2024
… request structures
andy89923
reviewed
Nov 17, 2024
Comment on lines
+142
to
+158
| postChargingDataRequest := &ConvergedCharging.PostChargingDataRequest{ | ||
| ChfConvergedChargingChargingDataRequest: req, | ||
| } | ||
| rspPost, localErr := client.DefaultApi.PostChargingData(ctx, postChargingDataRequest) | ||
|
|
||
| switch err := localErr.(type) { | ||
| case openapi.GenericOpenAPIError: | ||
| switch errModel := err.Model().(type) { | ||
| case ConvergedCharging.PostChargingDataError: | ||
| chargingDataRef := strings.Split(errModel.Location, "/") | ||
| smContext.ChargingDataRef = chargingDataRef[len(chargingDataRef)-1] | ||
| return nil, &errModel.ProblemDetails, nil | ||
| case error: | ||
| return nil, openapi.ProblemDetailsSystemFailure(errModel.Error()), nil | ||
| default: | ||
| return nil, nil, openapi.ReportError("openapi error") | ||
| } |
There was a problem hiding this comment.
The logic is not correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.