Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add maintainer field #11

Merged
merged 1 commit into from
Jan 9, 2025
Merged

add maintainer field #11

merged 1 commit into from
Jan 9, 2025

Conversation

chris-martin
Copy link
Contributor

@chris-martin chris-martin commented Jan 8, 2025 •
edited
Loading

#9

Add maintainer field so Hackage will accept. (There's probably a way to add a "will be accepted by hackage" check to CI?)

@chris-martin chris-martin requested a review from a team as a code owner January 8, 2025 22:14
@chris-martin chris-martin enabled auto-merge (squash) January 8, 2025 22:15
@chris-martin chris-martin changed the title add maintainer field, regenerate add maintainer field Jan 8, 2025
@chris-martin chris-martin requested review from a team and cristygrant and removed request for a team and cristygrant January 8, 2025 22:35
pbrisbin
pbrisbin approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@pbrisbin pbrisbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a "will be accepted by hackage" check to CI?

IIUC, stack sdist will check the package for such things. I'm not sure if it emits a useful exit code based on those checks though. There may be other ways.

@chris-martin chris-martin merged commit f33d05a into main Jan 9, 2025
9 checks passed
@chris-martin chris-martin deleted the chris/maintainer branch January 9, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbrisbin pbrisbin pbrisbin approved these changes

@OlaoluwaM OlaoluwaM Awaiting requested review from OlaoluwaM OlaoluwaM is a code owner automatically assigned from freckle/backenders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-martin @pbrisbin