Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code #1

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Initial code #1

merged 1 commit into from
Oct 10, 2024

Conversation

chris-martin
Copy link
Contributor

@chris-martin chris-martin commented Oct 9, 2024

A start on https://app.asana.com/0/home/1205102828747536/1207731129044880

I've opted to check the spec into this repo, because if for some reason it changes under us, I'd like to be able to see easily whether it was the spec that changed or the code generator.

Unlike most projects, there's no --pedantic and no hlint in the build, because they wouldn't pass and we don't care.

The generation is done via Just and Nix, which I guess are both controversial. I found Nix quite expedient since it provides the build dependencies, and Just expedient because I don't remember how to write a Makefile anymore, but we could add another build system alternative if desired.

Some regex replacements are done with perl, which I don't really know well, but is there a better cross-platform way to this? (sed has the stupid linux/macos difference with -i)

todo:

  • add a readme
  • get some additional metadata into the cabal file
  • add a github release workflow

@chris-martin chris-martin requested a review from pbrisbin October 10, 2024 00:00
@pbrisbin pbrisbin removed their request for review October 10, 2024 11:08
@mjgpy3
Copy link

mjgpy3 commented Oct 10, 2024

The generation is done via Just and Nix, which I guess are both controversial

I wouldn't say they're "controversial" as much as they're unfamiliar to the team. I'm personally fine with both of them being in this project -- it's just worth noting that there's more to know/learn for other maintainers.

Some regex replacements are done with perl, which I don't really know well, but is there a better cross-platform way to this?

This is likely good enough if it works for our local setups and GHA.

@mjgpy3
Copy link

mjgpy3 commented Oct 10, 2024

How much of this is from our haskell project template?

In other words, are there specific areas you'd like reviewed here?

@chris-martin
Copy link
Contributor Author

Good question, the only things not generated or from the template are:

  • Justfile
  • generator-config.yaml
  • version.txt

Copy link

@mjgpy3 mjgpy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chris-martin chris-martin merged commit cb3e590 into main Oct 10, 2024
4 checks passed
@chris-martin chris-martin deleted the chris/init branch October 10, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants