Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more Persistent functions, remove one #6

Merged
merged 4 commits into from
Jan 21, 2025
Merged

add more Persistent functions, remove one #6

merged 4 commits into from
Jan 21, 2025

Conversation

chris-martin
Copy link
Contributor

  • I had omitted selectSource intentionally because persistent's streaming doesn't really work (selectSource does not stream results yesodweb/persistent#657) but should have omitted selectKeys for the same reason, so this removes it now.
  • There are nine functions that should have been included but were accidentally omitted; this adds them.

@chris-martin chris-martin requested a review from a team as a code owner January 17, 2025 08:20
@chris-martin chris-martin requested review from stackptr and removed request for a team January 17, 2025 08:20
@chris-martin chris-martin enabled auto-merge (squash) January 17, 2025 08:21
@chris-martin chris-martin merged commit fdf2871 into main Jan 21, 2025
8 checks passed
@chris-martin chris-martin deleted the chris/more-stuff branch January 21, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-lieb jason-lieb jason-lieb approved these changes

@stackptr stackptr Awaiting requested review from stackptr stackptr is a code owner automatically assigned from freckle/backenders

@mjgpy3 mjgpy3 Awaiting requested review from mjgpy3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-martin @jason-lieb