Report PRs with required status failures #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to test locally. The defaults now match the defaults in `action.yml`, except for `DRY_RUN`, naturally.
Assuming PRs are left to mergeabot, these failures would never be visible to the team since the reviewer has been removed and the assumption is that the PR will pass and be merged eventually. We raise visibility in 3 ways here: 1. Report on each PR which required statuses failed, if any 2. Report at the end the list of such PRs 3. Set `failed` and `failed-urls` outputs for further action
pbrisbin
commented
May 14, 2024
Comment on lines
+97
to
+100
| gh api \ | ||
| "/repos/$GH_REPO/branches/$defaultBranch/protection" \ | ||
| --jq '.required_status_checks.contexts[]' | | ||
| sort >"$tmp/required-statuses.txt" |
There was a problem hiding this comment.
Hmm, so this requires a permission that I'm not sure Actions is able to even request.
That might be a deal-breaker for this whole idea.
There was a problem hiding this comment.
I think the choices are:
- Ask for the list of required statuses as an input, or
- Do this if any status checks fail
There was a problem hiding this comment.
Is there some way to attempt a merge, which would be rejected if a required status is failed?
There was a problem hiding this comment.
That's a good idea. I don't know what happens if a bot tries to merge around branch protections, I guess we'd have to test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default variables in-script too
19024e8
This makes it easier to test locally. The defaults now match the
defaults in
action.yml, except forDRY_RUN, naturally.Report PRs with required status failures
995ab99
Assuming PRs are left to mergeabot, these failures would never be
visible to the team since the reviewer has been removed and the
assumption is that the PR will pass and be merged eventually.
We raise visibility in 3 ways here:
failedandfailed-urlsoutputs for further action