Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Revamped signup flow #2372

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

refactor: Revamped signup flow #2372

wants to merge 36 commits into from

Conversation

BreadGenie
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 4.42478% with 216 lines in your changes missing coverage. Please review.

Project coverage is 38.07%. Comparing base (6b962e0) to head (29bbeb7).

Files with missing lines Patch % Lines
press/api/product_trial.py 0.00% 62 Missing ⚠️
press/saas/doctype/site_user/site_user.py 0.00% 50 Missing ⚠️
press/api/developer/saas.py 0.00% 41 Missing ⚠️
press/api/marketplace.py 8.33% 22 Missing ⚠️
press/saas/doctype/product_trial/product_trial.py 13.04% 20 Missing ⚠️
press/press/doctype/site/site.py 13.33% 13 Missing ⚠️
...ype/product_trial_request/product_trial_request.py 25.00% 6 Missing ⚠️
press/api/account.py 50.00% 1 Missing ⚠️
press/press/doctype/team/team.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
- Coverage   38.29%   38.07%   -0.22%     
==========================================
  Files         379      380       +1     
  Lines       29795    29979     +184     
==========================================
+ Hits        11410    11416       +6     
- Misses      18385    18563     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BreadGenie BreadGenie changed the title refactor: revamped signup flow refactor: Revamped signup flow Jan 10, 2025
@rmehta
Copy link
Member

rmehta commented Jan 20, 2025

Any update?

@rmehta
Copy link
Member

rmehta commented Jan 27, 2025

Do add latest videos / screenshots on this thread as well.

- user can login to their site irrespective of if they have account in press, since we will store the user site map for every site
- use session log dt for otp stuff
- use cookies to keep session for 5 days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants