Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make it preemtible with pending upstream PRs #2251

Merged

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Oct 1, 2024

Example usage: frappe/erpnext#43473, #2252

@ruchamahabal could you merge for convenience?

@blaggacao blaggacao force-pushed the feat/incorporate-read-only-mode-mapper branch from 57bdcfc to a9d632b Compare October 7, 2024 11:32
@blaggacao
Copy link
Contributor Author

blaggacao commented Oct 7, 2024

@ruchamahabal Could you please merge this? It allows to validate if upstream PRs break downstream behaviour.

Otherwise, there is only the "screem test" * left and that's not ideal.

* go ahead and see if it hurts hrms downstream and then do damage control

Looks like we already have a damage control case here: #2259

@ruchamahabal ruchamahabal merged commit 484f19c into frappe:develop Oct 23, 2024
6 of 7 checks passed
@blaggacao blaggacao deleted the feat/incorporate-read-only-mode-mapper branch October 23, 2024 10:37
@blaggacao
Copy link
Contributor Author

Thanks @ruchamahabal ! Much appreciated! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants