Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique component name in transform-script.js #2

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

biguphpc
Copy link
Contributor

See (framework7io/framework7#4244) for more info

Avoid error Error: InvalidCharacterError: Failed to execute 'createElement' on 'Document': The tag name provided ('$') is not a valid name.

Name components using unique is as part of the coponent name function so they don't collide. This way rollup or other minifiers don't try to use $N in the names

@nolimits4web
Copy link
Member

t0ggles-create f7

Copy link

t0ggles bot commented Mar 18, 2024

Task nolimits4web/F7-66 was created

t0ggles task F7-66

@nolimits4web nolimits4web merged commit aaefce0 into framework7io:master Mar 19, 2024
Copy link

t0ggles bot commented Mar 19, 2024

Task nolimits4web/F7-66 status changed to Done

@nolimits4web
Copy link
Member

Merged, thanks!

@biguphpc
Copy link
Contributor Author

biguphpc commented Apr 6, 2024

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants