Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guus/compose var type check #874

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Guus/compose var type check #874

merged 8 commits into from
Dec 5, 2023

Conversation

guusw
Copy link
Member

@guusw guusw commented Nov 24, 2023

No description provided.

@sinkingsugar
Copy link
Member

Can we wrap this @guusw ?

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (c4efe24) 80.79% compared to head (38be987) 80.76%.
Report is 26 commits behind head on devel.

Files Patch % Lines
shards/core/type_matcher.hpp 79.24% 22 Missing ⚠️
shards/gfx/enums.cpp 0.00% 9 Missing ⚠️
shards/core/foundation.hpp 86.66% 2 Missing ⚠️
shards/core/exposed_type_utils.hpp 94.44% 1 Missing ⚠️
shards/modules/gfx/view.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #874      +/-   ##
==========================================
- Coverage   80.79%   80.76%   -0.04%     
==========================================
  Files         290      291       +1     
  Lines       38115    38209      +94     
==========================================
+ Hits        30796    30858      +62     
- Misses       7319     7351      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guusw guusw merged commit bd95479 into devel Dec 5, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants