Add wpsModifyResponseHeaders function
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new function to the `WaiProxySettings` that allows modifying the response headers before they are sent upstream.
snoyberg
approved these changes
Jun 18, 2024
snoyberg
reviewed
Jun 18, 2024
Unfortunately I'm father of two small twins, so time is really tight for me as well 😉 I'm happy to occasionally help, but I'm afraid that as far as comaintenance goes, I have to decline, sorry 😢 |
|
Congratulations on the twins! |
Thanks! They are 2.5 years old now, but they are demanding to say the least 😅 I haven't forgot making amendments on this PR, but I'm out of hours for this particular client, so I will deal with those next week :) Take care! |
|
Wow small world, my twins are also 2.5 years old! |
snoyberg
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @snoyberg ,
I hope you are safe and healthy.
This commit adds a new function to the
WaiProxySettingscalledwpsModifyResponseHeaders, that allows modifying the response headers before they are sent upstream. The primary usage would be for example to tweak things like theContent-Security-Policythat now modern browsers are enforcing when it comes to static content, and that needs to be amended in case the proxied server is too stringent.If you are not fan of the approach let me know, I'm happy to make changes as needed.
Take care,
Alfredo