Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stack & flamegraph with minor fixes #11

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Conversation

flip111
Copy link
Contributor

@flip111 flip111 commented Feb 5, 2018

  • Update stack lts to 10.4
  • Update FlameGraph toa8d807a on Aug 18, 2017
  • Add Paths_ghc_prof_flamegraph to other-modules in cabal file to avoid compile
    warnings
  • add .gitignore for local .stack-work directory

* Update stack lts to 10.4
* Update FlameGraph toa8d807a on Aug 18, 2017
* Add Paths_ghc_prof_flamegraph to other-modules in cabal file to avoid compile
  warnings
* add .gitignore for local .stack-work directory
@flip111
Copy link
Contributor Author

flip111 commented Feb 5, 2018

The travis test is cheating a little bit by not testing my stack lts update see #12

But i tested it with this prof file and got a good looking svg ... i think it's sufficient tested with this.

@thomasjm
Copy link

thomasjm commented Jun 7, 2018

This patch works well for me, would it be possible to merge?

@mgsloan
Copy link
Contributor

mgsloan commented Jun 7, 2018

LGTM! Thanks for the patch @flip111 and thanks for the ping @thomasjm

@mgsloan mgsloan merged commit 8edd3b4 into fpco:master Jun 7, 2018
fommil pushed a commit to platonic-io/prof-flamegraph that referenced this pull request May 21, 2019
Update stack & flamegraph with minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants