Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emulsify base theme #11

Open
wants to merge 63 commits into
base: main
Choose a base branch
from
Open

feat: Emulsify base theme #11

wants to merge 63 commits into from

Conversation

callinmullaney
Copy link

@callinmullaney callinmullaney commented Mar 11, 2024

This PR does the following:

  • Adds the Emulsify base theme
  • Generates and installs an emulsify subtheme during project setup
  • Removed old theme dependency emulsify_twig and installs a new, forked dependency emulsify_tools

Functional Testing:

  • run composer create-project fourkitchens/sous-drupal-project:dev-emulsify-base-theme webchef --no-interaction
  • Verify this command sets up a project called webchef
  • Log into Drupal with the provided temporary link - The webchef project should have emulsify_tools installed, emulsify (base theme) installed and enabled from web/themes/contrib/emulsify, and generates a subtheme call webchef that is enabled as the default frontend theme.
  • Verify that the theme tools (web/themes/custom/webchef/node_modules) are present
  • run lando theme-watch and verify a storybook URL is provided with an empty component library - See note below
    Screenshot 2024-03-11 at 8 57 57 AM

Note:

  • The project setup above should all function but Compound isn't installed by default and currently has some compatibility issues with the recent version of sass. These are being resolved outside of this PR.

laura-johnson and others added 25 commits January 8, 2024 13:16
Add config changes through actions in sous_admin
feat: sous-25 create default content types recipe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants