🐛 Fix logMemory in safeconsole

[Philogy]

The safeconsole.logMemory method did not work as expected because it was calling the logBytes(bytes) method on the console pre-compile and not log(bytes).

I furthermore marked all assembly blocks as "memory safe" as it doesn't change memory and to prevent it from conflicting with certain viaIR optimizations.

[mds1]

Sorry where is log(bytes) defined? I do not see that method in the console libraries

[Philogy]

Sorry where is log(bytes) defined? I do not see that method in the console libraries

@mds1

forge-std/src/console.sol

Lines 53 to 55 in 2cbff06

	function logBytes(bytes memory p0) internal pure {
	_sendLogPayload(abi.encodeWithSignature("log(bytes)", p0));
	}

[mds1]

That signature you linked is logBytes(bytes) which is 0xe17bf956 (what was originally in console.sol), but the PR changes it log(bytes) (0x0be77f56) and I don't see a function log(bytes) defined anywhere

[Philogy]

That signature you linked is logBytes(bytes) which is 0xe17bf956 (what was originally in console.sol), but the PR changes it log(bytes) (0x0be77f56) and I don't see a function log(bytes) defined anywhere

So the library function is called logBytes(bytes) (which is also why I initially put that) but it dispatches out (the actual call to the underlying "console pre-compile" address) log(bytes).

You can try it yourself locally by testing the code from my PR:

// SPDX-License-Identifier: MIT
pragma solidity ^0.8.0;

import {Test} from "../src/Test.sol";
import {safeconsole} from "../src/safeconsole.sol";

/// @author philogy <https://github.com/philogy>
contract safeconsoleTest is Test {
    struct A {
        uint256 a;
        uint256 b;
    }

    function test_logMemory() public pure {
        A memory a = A(uint256(keccak256("a")), uint256(keccak256("b")));
        safeconsole.logMemory(0x00, 0x100);
    }
}

Here also a link to foundry's actual definition of the underlying console interface: https://github.com/foundry-rs/foundry/blob/master/crates/evm/abi/src/HardhatConsole.json (you can use this query jq '[.[] | select(.inputs | map(.type) | any(. == "bytes"))]' HardhatConsole.json to find the log(bytes) method)

[mds1]

I see now, thank you! Not sure how I missed that when you linked to this 😅

forge-std/src/console.sol

Lines 53 to 55 in 2cbff06

	function logBytes(bytes memory p0) internal pure {
	_sendLogPayload(abi.encodeWithSignature("log(bytes)", p0));
	}

[Philogy]

No worries, happens, thanks for being so responsive!