Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate GitHub Actions #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Integrate GitHub Actions #19

wants to merge 2 commits into from

Commits on Apr 14, 2020

  1. Integrate GitHub Actions 

    Define a GitHub Actions CI pipeline that builds for Linux on MSRV,
stable, and next, and makes a half-arsed attempt at verifying MSRV on
Windows.

Because several dependencies rely on wildcards the de facto MSRVs are a
fair bit higher than advertised:

- getopts unceremoniously abandoned MSRV pretence in 0.2.20 and raised
  MSRV from 1.18 to 1.27, then again to 1.31 in 0.2.21.
- libloading 0.6.0 for "unix" uses MaybeUninit, which requires 1.36.
- libloading 0.6.0 for "windows" uses pointer::cast(), which requires
  1.38, and the non_exhaustive feature, which requires 1.40.

Of course, the original MSRVs can be restored by fixing dependencies.

I've retained the Linux/Windows MSRV split out of precedence. It makes
some sense given the build dependency difference, though I'd argue for
simplifying communication by maintaining only one MSRV.
    @commonquail
    commonquail committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    bcfd45d View commit details
    Browse the repository at this point in the history

  2. Document de-facto MSRV 

    See commit bcfd45d ("Integrate GitHub Actions", 2020-04-14) for details
about this bump.
    @commonquail
    commonquail committed Apr 14, 2020
    Configuration menu
    Copy the full SHA
    669dc3e View commit details
    Browse the repository at this point in the history