Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with #93
and makes that time unit is
milliseconds since 1970-01-01
in vgac and gac files,by using a floating point datatype instead of int. Note also that that two time variables are present in these files:
Tis PR only modify the scanline_timestamps variable.
We still get a warning from satpy/writers/cf_writer.py, as you can see by checking the details of the test, or more exactly it comes from xarray. Xarray cast time variables to np.datetime64[ns] datatype. I guess the warnings comes from that it is not possible to serialize this to some other datatype / units without loosing precision. I understand this warning is useful if you really care about the the nano-second precision, but sine we do not do that I guess we can ignore the warning.
Anyhow, if I use "nanoseconds since 1970-01-01" as unit I get rid of the warnings, but whatever else I try result in warnings with "moment 22" suggestions for solutions.
Not clear to me if this PR actually closes the issue, since it modifies the datatype of the variable and we still get warnings,
but we at least get
milliseconds since 1970-01-01
as unit.pytest level1c4pps
flake8