Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vgac cli bugfix #95

Merged
merged 1 commit into from
Oct 18, 2024
Merged

vgac cli bugfix #95

merged 1 commit into from
Oct 18, 2024

Conversation

BengtRydberg
Copy link
Contributor

using correct keyword.

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest level1c4pps
  • Passes flake8
  • Fully documented

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11381234968

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.273%
Totals Coverage Status
Change from base Build 11367953830: 0.0%
Covered Lines: 1612
Relevant Lines: 1969
💛 - Coveralls

ninahakansson
ninahakansson approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ninahakansson ninahakansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BengtRydberg BengtRydberg merged commit 0b7b95d into foua-pps:main Oct 18, 2024
8 checks passed
@BengtRydberg BengtRydberg deleted the vgac_cli_bug_fix branch October 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninahakansson ninahakansson ninahakansson approved these changes

@salomoneliassonSMHI salomoneliassonSMHI Awaiting requested review from salomoneliassonSMHI

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BengtRydberg @coveralls @ninahakansson