Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support for handling mersi3 data #91

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Conversation

BengtRydberg
Copy link
Contributor

@BengtRydberg BengtRydberg commented Aug 15, 2024

Adding support for handling mersi3 data by renaming and extending the mersi2 script to also handle mersi3 data.

  • Tests added
  • Tests passed: Passes pytest level1c4pps
  • Passes flake8
  • Fully documented (don't really know what is needed)

@BengtRydberg BengtRydberg changed the title adding support for handling merci3 data by renaming and ext adding support for handling merci3 data Aug 15, 2024
@BengtRydberg BengtRydberg changed the title adding support for handling merci3 data adding support for handling mersi3 data Aug 15, 2024
@coveralls
Copy link

coveralls commented Aug 15, 2024

Pull Request Test Coverage Report for Build 11234376042

Details

  • 48 of 68 (70.59%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 80.124%

Changes Missing Coverage Covered Lines Changed/Added Lines %
level1c4pps/tests/init.py 0 1 0.0%
level1c4pps/tests/test_mersi2pps.py 18 19 94.74%
level1c4pps/mersi2pps_lib.py 30 48 62.5%
Totals Coverage Status
Change from base Build 10386821954: 0.6%
Covered Lines: 1605
Relevant Lines: 1963

💛 - Coveralls

@BengtRydberg BengtRydberg marked this pull request as ready for review September 5, 2024 14:16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to keep the possibility to also run mersi22pps.py until next release of PPS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I see. Do you know if it is possible to fix this through the setup.py file, so we don't need duplicated files? If one use entry_points in setup.py, this should be possible, but the bin directory is not a package so a bit tricky. Or should I just keep the old mersi22pps.py file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added mersi22pps.py as a symbolic link to mersi2pps.py. Is this an acceptable solution?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be fine!

@ninahakansson ninahakansson merged commit a274565 into main Oct 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants