-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for handling mersi3 data #91
Conversation
Pull Request Test Coverage Report for Build 11234376042Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to keep the possibility to also run mersi22pps.py until next release of PPS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I see. Do you know if it is possible to fix this through the setup.py file, so we don't need duplicated files? If one use entry_points in setup.py, this should be possible, but the bin directory is not a package so a bit tricky. Or should I just keep the old mersi22pps.py file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added mersi22pps.py as a symbolic link to mersi2pps.py. Is this an acceptable solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be fine!
Adding support for handling mersi3 data by renaming and extending the mersi2 script to also handle mersi3 data.
pytest level1c4pps
flake8