Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VGAC converter #77

Merged
merged 22 commits into from
May 16, 2024
Merged

VGAC converter #77

merged 22 commits into from
May 16, 2024

Conversation

ninahakansson
Copy link
Collaborator

@ninahakansson ninahakansson commented Mar 3, 2023

Converter for VGAC

  • Closes #xxxx
  • Tests added
  • Tests passed: Passes pytest level1c4pps
  • Passes flake8
  • Fully documented

@coveralls
Copy link

coveralls commented Mar 3, 2023

Pull Request Test Coverage Report for Build 8750054478

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 115 of 126 (91.27%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 79.022%

Changes Missing Coverage Covered Lines Changed/Added Lines %
level1c4pps/init.py 1 4 25.0%
level1c4pps/tests/test_vgac2pps.py 55 59 93.22%
level1c4pps/vgac2pps_lib.py 59 63 93.65%
Files with Coverage Reduction New Missed Lines %
level1c4pps/viirs2pps_lib.py 10 50.0%
Totals Coverage Status
Change from base Build 8203135286: 0.7%
Covered Lines: 1518
Relevant Lines: 1869

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 74.43%. Comparing base (e7e5465) to head (d62a3b3).
Report is 3 commits behind head on main.

❗ Current head d62a3b3 differs from pull request most recent head 7399c55. Consider uploading reports for the commit 7399c55 to get more accurate results

Files Patch % Lines
level1c4pps/vgac2pps_lib.py 0.00% 62 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   77.37%   74.43%   -2.94%     
==========================================
  Files          21       22       +1     
  Lines        1472     1514      +42     
  Branches      125      114      -11     
==========================================
- Hits         1139     1127      -12     
- Misses        306      363      +57     
+ Partials       27       24       -3     
Flag Coverage Δ
unittests 74.43% <0.00%> (-2.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ninahakansson ninahakansson marked this pull request as ready for review April 25, 2024 11:22
@ninahakansson ninahakansson merged commit f35271d into foua-pps:main May 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants