-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the test code to use pytest #124
Conversation
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 정도면 거의 2, 3단계까지 완료하신 수준인 것 아닌가요? 조용히 작업해주셔서 모르고 있다가 깜짝 놀랐습니다 ㅎㅎ... 특히 mocking 사용해주신 부분은 저도 배워갑니다!
분량이 분량이다보니 리뷰가 이것저것 많이 달린 것 같은데 대부분 사소한 것들인 것 같아서 편하게 봐주시면 될 것 같아요! 궁금하신 점 있으시면 말씀 부탁드립니다. 고생 많으셨어요~
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아직 해결하지 못 한 문제가 있다고 하셔서 러프하게 코멘트 달았습니다!
전체적으로 깔끔한 것 같네요 :)
- PR 설명에서 Type of change Refactoring으로 변경하셔야 할 것 같습니다 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엄청 열심히 짜신 것 같습니다 ㄷㄷ 수고하셨습니다!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 :) 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저도 다른 리뷰어분들이 남겨주신 질문들이 궁금합니다. 답변 달아주시면 참고하겠습니다. 수고하셨습니다! :)
@cjho0316 , 수정 완료된 커맨트에 답변 남겨주시고, Resolve conversation 클릭해주십시오. |
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Signed-off-by: cjho0316 <[email protected]>
Description
Change existing test to pytestwhat I've done in this PR:
Type of change
Please insert 'x' one of the type of change.