-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change command for flashing firmware #181
Conversation
Reviewer's Guide by SourceryThis pull request updates the firmware flashing instructions in the README.md file, replacing the use of 'pslab flash' command with 'mcbootflash' command. It also adds information about the mcbootflash tool and its installation. User journey diagram for firmware flashing processjourney
title Firmware Flashing Process
section Preparation
User: Press 'BOOT' button
User: Release 'BOOT' button
section Flashing
User: Run `mcbootflash --port <portname> -b 460800 firmware.hex`
section Completion
User: Reset or power cycle the device
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marcnause - I've reviewed your changes - here's some feedback:
Overall Comments:
- Could you provide more context on why
pslab flash
doesn't work and whether this change with mcbootflash is intended to be a temporary workaround or a permanent solution? - Please elaborate on the implications of introducing mcbootflash as a new dependency. Are there any compatibility issues to consider, and have you tested this method across different environments and devices?
- There's a typo in the PR title ('fiormware' instead of 'firmware'). Please correct it for clarity.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Thank you! |
Flashing via
pslab flash
does not work currently, but using mcbootflash as a fallback works.Summary by Sourcery
Documentation:
pslab flash
tomcbootflash
.