-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sensors.md #133
Update sensors.md #133
Conversation
Reviewer's Guide by SourceryThis pull request significantly updates the 'sensors.md' file, expanding the content with detailed information about sensors, their types, and example experiments using the Pocket Science Lab (PSLab). The changes provide a comprehensive overview of sensors, distinguishing between analog and digital types, and include two practical experiments to demonstrate sensor usage with PSLab. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Satarupa22-SD - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Analog sensors produce a continuous output signal that is proportional to the measured quantity. | ||
|
||
|
||
Key characteristics: | ||
- Output is a continuous range of values | ||
- Can detect small changes in the input | ||
- Often require analog-to-digital conversion for use with digital systems | ||
- Examples: thermistors, photoresistors, potentiometers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider adding information about resolution differences between analog and digital sensors.
This could help users understand another key distinction between these sensor types.
Analog sensors produce a continuous output signal that is proportional to the measured quantity. | |
Key characteristics: | |
- Output is a continuous range of values | |
- Can detect small changes in the input | |
- Often require analog-to-digital conversion for use with digital systems | |
- Examples: thermistors, photoresistors, potentiometers | |
Analog sensors produce a continuous output signal that is proportional to the measured quantity. | |
Key characteristics: | |
- Output is a continuous range of values | |
- Higher resolution compared to digital sensors | |
- Can detect small changes in the input | |
- Often require analog-to-digital conversion for use with digital systems | |
- Typically provide more precise measurements than digital sensors | |
- Examples: thermistors, photoresistors, potentiometers |
|
||
|
||
Procedure : | ||
1. Connect the digital sensor to the appropriate pins on the PSLab (likely power, ground, and a digital data pin). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (documentation): Consider mentioning that exact pin connections may vary depending on the sensor model.
1. Connect the digital sensor to the appropriate pins on the PSLab (likely power, ground, and a digital data pin). | |
1. Connect the digital sensor to the appropriate pins on the PSLab (typically power, ground, and a digital data pin). Note: Exact pin connections may vary depending on the specific sensor model being used. |
@mariobehling @orangecms please look into it and let me know if any changes are needed. Thanks! |
#89
What changes have you introduced?
updated missing information regarding sensors
Does this PR introduce a breaking change?
No
Summary by Sourcery
Update the 'sensors.md' documentation to provide comprehensive information on sensors, including definitions, types, and practical experiments using the Pocket Science Lab (PSLab).
Documentation: