Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes API for fetching tweets #2021

Closed
wants to merge 1 commit into from

Conversation

agbilotia1998
Copy link
Member

@agbilotia1998 agbilotia1998 commented Jul 13, 2018

Checklist

Short description of what this resolves:

Changes API for fetching tweets, which provides only the tweets made by the organizer and also shows response with the retweets made.

Link to server: https://webapp-generator.herokuapp.com/
Test endpoint:

Fixes #2017

@agbilotia1998
Copy link
Member Author

agbilotia1998 commented Jul 13, 2018

The proposed solution is an alternative to loklak API. I checked the documentation of the search API but either all the tweets(Also not by the organizer - #1363) or only specific tweets(Not including the retweets - https://sched.eventyay.com/GoogleIO2017/ and http://2018.fossasia.org/ [Current implemetation]) are sent as the response. If there is any other solution or configuration to existing solution that can be made please let me know. Please review @geekyd @shubham3211 @pradeepgangwar

@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #2021 into development will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #2021   +/-   ##
============================================
  Coverage        72.07%   72.07%           
============================================
  Files                9        9           
  Lines             2328     2328           
  Branches           412      412           
============================================
  Hits              1678     1678           
  Misses             650      650
Impacted Files Coverage Δ
src/backend/gulpfile.js 74.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae643a...837d2f6. Read the comment docs.

@mariobehling
Copy link
Member

The goal is to keep the loklak API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No tweets displayed for samples
2 participants