-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature-8683: Add Options for Badges in Wizard #8968
Conversation
Lthanhhieu tma/feature 8683
imeplemnent save badge
Khangon tma/feature 8683
Merge pull request #4 from khangon/khangon_tma/feature-8683
feature-8683: Add Options for Badges in Wizard
Khangon tma/feature 8683
Lthanhhieu tma/feature 8683
Khangon tma/feature 8683
Hi @cweitat , @mariobehling , @norbusan |
@lthanhhieu do update the api documentation |
@lthanhhieu Please solve pytype error.
|
Thanks, please also check dredd tests. Looks like there is an issue with the PDF.
|
app/api/custom/badge_forms.py
Outdated
) | ||
|
||
|
||
@badge_forms_routes.route('/preivew-badge-pdf', methods=['POST']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be preview-badge-pdf
not preivew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you. I fixed it
API for #8982 Get list of badge fields to print [/v1/tickets/int:ticket_id/badge-forms]Get list of badge fields to print [GET]Get the list of badge fields to print using JWT token
API for #8955 Return a PDF for badge printing from server [/v1/badge-forms/print-badge-pdf]Return a PDF for badge printing from server [POST]Return a PDF for badge printing from server using JWT token
|
As discussed privately off-site I am merging this for functional testing. Thanks. |
Fixes:
Short description of what this resolves:
Changes proposed in this pull request:
Checklist
development
branch.