Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-8914: Update spelling and translations of attendee form #8953

Merged
merged 2 commits into from
Jul 13, 2023
Merged

fix-8914: Update spelling and translations of attendee form #8953

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0243844
fix-8914: Update spelling and translations of attendee form
odkhang Jul 6, 2023
bf1d17e
Merge branch 'development' into khangon_tma/fix-8914
khangon Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/custom_form.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
"acceptVideoRecording": "Photo & video & text consent",
"acceptShareDetails": "Partner contact consent",
"acceptReceiveEmails": "Email consent",
"is_consent_form_field": "Consent form field",
"is_consent_form_field": "Code of conduct consent",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be "is_consent_form_coc"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably be "is_consent_form_coc"

This will change the column name in database, I think it will take time to do for it @mariobehling

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then lets not do it now, but we should have caught this earlier. It does not make sense to just call it "consent form field". Anyways, thanks.

"is_consent_form_field_photo": "Wikimania photo consent",
"is_consent_form_field_email": "Wikimania email updates",
"is_consent_of_refund_policy": "Consent of refund policy",
Expand Down