Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change naming of form questions #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change naming of form questions #31

wants to merge 1 commit into from

Conversation

Aryan20
Copy link
Contributor

@Aryan20 Aryan20 commented Feb 12, 2024

Form questions:

Change naming ->

  1. “Choose one from a list” to “Radio button (Choose one option)”
  2. “Choose multiple from a list” to “Checkbox (Choose one or several options)”

This is done to better reflect what these options do.

fixes: #12

image

Checklist

  • I have added tests to cover my changes.
  • I have updated the documentation.
  • My change is listed in the doc/changelog.rst.

@Aryan20
Copy link
Contributor Author

Aryan20 commented Feb 12, 2024

Do I also need to update changelogs and docs?

@Aryan20 Aryan20 mentioned this pull request Feb 12, 2024
Open
3 tasks
@mariobehling
Copy link
Member

Do I also need to update changelogs and docs?

yes, please

mariobehling
mariobehling requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of unrelated PO file changes in this PR that should not be there.

@Aryan20
Change naming of form questions
ac7680a 
Form questions:
1) Change naming “Choose one from a list” to “Radio button (Choose one option)”
2) “Choose multiple from a list” to “Checkbox (Choose one or several options)”

This is done to better reflect what these options do.

fixes: fossasia#12
@Aryan20
Copy link
Contributor Author

Aryan20 commented Feb 15, 2024

Done, apologies for the delay

@norbusan
Copy link
Member

@mariobehling are you fine with the renaming? I am not sure which of those is actually better understandable.
Other than this, if we merge this change, we loose all the translations of this text, which by itself even worse.
So I am not convinced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariobehling mariobehling mariobehling approved these changes

@norbusan norbusan Awaiting requested review from norbusan

@marcoag marcoag Awaiting requested review from marcoag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change naming of form questions
3 participants
@Aryan20 @mariobehling @norbusan