feat: Added the UI to display the vectors on prefix Icon Click. #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityastic
reviewed
Jul 14, 2024
lib/constants.dart
Outdated
| @@ -14,3 +14,46 @@ const String aniRight = 'assets/animations/ic_anim_right.gif'; | |||
| const String effFlash = 'assets/effects/ic_effect_flash.gif'; | |||
| const String effInvert = 'assets/effects/ic_effect_invert.gif'; | |||
| const String effMarque = 'assets/effects/ic_effect_marquee.gif'; | |||
|
|
|||
| //list containing the location of all the assets | |||
| List<String> vectors = [ | |||
There was a problem hiding this comment.
Instead of maintaining the list of vectors. Can you try to read all vectors from this location? We don't want to maintain a list as well as the asset where we could infer by reading the AssetManifest.json
|
|
||
| //function to load and scale the svg according to the badge size | ||
| Future<ui.Image> scaleSVG(String svg) async { | ||
| late ui.Picture picture; |
There was a problem hiding this comment.
Sharing the picture when not designing the class to handle per image operations would be confusing. If this class is going to process one image anyway. Remove gateways to loadSVG, scaleSVG, etc by making them private
lib/view/splashscreen.dart
Outdated
| _startImageCaching(); | ||
| } | ||
|
|
||
| Future<void> _startImageCaching() async { |
There was a problem hiding this comment.
We wanted to remove the splash screen. Do we want to still want to process the images here?
adityastic
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#954