Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated the UI of the speed dial and made some color changes in the file #1149

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

Jhalakupadhyay
Copy link
Contributor

@Jhalakupadhyay Jhalakupadhyay commented Jan 6, 2025

#1129

Summary by Sourcery

Update the speed dial UI and adjust colors throughout the app.

Enhancements:

  • Increase the speed dial size and change the stroke width.
  • Change the color of the speed dial background circle.
  • Increase the font size of the speed dial value display.
  • Update the color of the save badge button to the primary color.
  • Change the color of the draw and erase buttons to the primary color when active.
  • Update the home screen container color to match the background circle color.
  • Change the dropdown icon color in the settings screen.
  • Update the color of the animation container card when active.
  • Update the color of the effects container card when active.
  • Change the color of the import button text on the save badge screen.

Copy link
Contributor

sourcery-ai bot commented Jan 6, 2025

Reviewer's Guide by Sourcery

This PR updates the UI of the speed dial and makes some color changes.

Class diagram for UI painter modifications

classDiagram
    class InnerDialPainter {
      +paint(Canvas, Size)
      note for InnerDialPainter "Modified radius: 0.6 -> 0.7
Changed color to backCircleColor
Increased strokeWidth: 1.w -> 10.w"
    }
    class RadialDialPainter {
      +paint(Canvas, Size)
      note for RadialDialPainter "Modified radius: 0.7 -> 0.8
Changed color to backCircleColor
Changed strokeWidth: 6.w -> 4.w"
    }
    class InnerPointerPainter {
      +paint(Canvas, Size)
      note for InnerPointerPainter "Modified radius: 0.4 -> 0.5"
    }
Loading

State diagram for color changes across UI components

stateDiagram-v2
    direction LR
    [*] --> Colors
    Colors --> SaveBadgeCard: Changed from red to colorPrimary
    Colors --> DrawBadge: Changed from red to colorPrimary
    Colors --> AnimationContainer: Changed from red/white to colorAccent/drawerHeaderTitle
    Colors --> EffectsContainer: Changed from red/white to colorAccent/drawerHeaderTitle
    Colors --> SettingsScreen: Changed dropdown icon to mdGrey400
Loading

File-Level Changes

Change Details Files
Increased the size of the speed dial and changed its color.
  • Increased the radius of the inner and outer dials.
  • Changed the color of the inner and outer dials to backCircleColor.
  • Increased the stroke width of the inner dial and decreased the stroke width of the outer dial.
  • Increased the size of the pointer in the inner dial.
  • Increased the font size of the text displayed in the speed dial from 40.sp to 50.sp.
lib/view/widgets/speedial.dart
Changed the color of the save badge button.
  • Changed the background color of the save badge button from red to colorPrimary.
lib/view/widgets/save_badge_card.dart
Changed the color of the draw and erase icons in the draw badge screen.
  • Changed the color of the draw and erase icons to colorPrimary when active and black when inactive, instead of red and black respectively.
lib/view/draw_badge_screen.dart
Updated the color and border radius of the container in the home screen.
  • Changed the background color of the container to backCircleColor.
  • Added a border radius to the container.
lib/view/homescreen.dart
Changed the color of the dropdown icons in the settings screen.
  • Changed the color of the dropdown icons from grey to mdGrey400.
lib/view/settings_screen.dart
Updated the color of the animation container card.
  • Changed the background color of the animation container card to colorAccent when active and drawerHeaderTitle when inactive, instead of red and white respectively.
lib/view/widgets/animation_container.dart
Updated the color of the effects container card.
  • Changed the background color of the effects container card to colorAccent when active and drawerHeaderTitle when inactive, instead of red and white respectively.
lib/view/widgets/effects_container.dart
Changed the color of the import button text on the save badge screen.
  • Changed the color of the import button text from white to drawerHeaderTitle.
lib/view/save_badge_screen.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Jhalakupadhyay - I've reviewed your changes - here's some feedback:

Overall Comments:

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@adityastic adityastic enabled auto-merge (squash) January 6, 2025 10:41
@adityastic adityastic merged commit e3d1fdf into fossasia:flutter_app Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants