-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use global scaffoldMessengerKey to display SnackBar #1137
Merged
adityastic
merged 1 commit into
fossasia:flutter_app
from
ZauberNerd:scaffoldmessengerkey
Jan 3, 2025
Merged
refactor: use global scaffoldMessengerKey to display SnackBar #1137
adityastic
merged 1 commit into
fossasia:flutter_app
from
ZauberNerd:scaffoldmessengerkey
Jan 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR refactors the way SnackBar messages are displayed by using a global Sequence diagram for displaying SnackBar messages after refactorsequenceDiagram
participant App as MaterialApp
participant Toast as ToastUtils
participant Global as globals.scaffoldMessengerKey
participant SM as ScaffoldMessenger
App->>Global: Initialize scaffoldMessengerKey
Toast->>Global: Access currentState
Global->>SM: Get ScaffoldMessenger state
Toast->>SM: showSnackBar(message)
SM-->>Toast: Display SnackBar
Class diagram showing the refactored SnackBar display mechanismclassDiagram
class ToastUtils {
-showToast(String message)
}
class globals {
+GlobalKey~ScaffoldMessengerState~ scaffoldMessengerKey
}
class MaterialApp {
+GlobalKey~ScaffoldMessengerState~ scaffoldMessengerKey
}
ToastUtils ..> globals : uses
MaterialApp --> globals : uses scaffoldMessengerKey
note for ToastUtils "Now uses global scaffoldMessengerKey
instead of GlobalContextProvider"
note for globals "New global utility for
ScaffoldMessenger state"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ZauberNerd - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ZauberNerd
force-pushed
the
scaffoldmessengerkey
branch
from
January 3, 2025 20:13
6dfee96
to
b70ad92
Compare
adityastic
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: https://medium.com/@rodrigorivasdev/using-scaffoldmessenger-with-key-d626b465a483
Summary by Sourcery
Use a global key to access the ScaffoldMessenger for displaying SnackBars.
New Features:
Enhancements: