Skip to content

Commit

Permalink
fix: updates the language of the dialog and adds permission flags in …
Browse files Browse the repository at this point in the history
…the manifest (#933)
  • Loading branch information
AsCress authored May 23, 2024
1 parent 6e6135a commit a369194
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
xmlns:tools="http://schemas.android.com/tools"
package="org.fossasia.badgemagic">

<uses-permission android:name="android.permission.BLUETOOTH_SCAN" />
<uses-permission android:name="android.permission.BLUETOOTH_SCAN"
android:usesPermissionFlags="neverForLocation"/>
<uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
<uses-permission android:name="android.permission.BLUETOOTH" />
<uses-permission android:name="android.permission.BLUETOOTH_ADMIN" />
Expand All @@ -12,7 +13,7 @@
<uses-feature android:name="android.hardware.bluetooth" android:required="true"/>
<uses-feature android:name="android.hardware.bluetooth_le" android:required="true"/>

<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
<uses-permission android:name="android.permission.ACCESS_FINE_LOCATION"/>

<uses-feature android:name="android.hardware.location.gps" />

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class BadgeMagicPermission private constructor() {
if (permission == Manifest.permission.ACCESS_FINE_LOCATION) {
val builder = AlertDialog.Builder(activity)
builder.setTitle("Location Permission Disclosure")
builder.setMessage("Badge Magic requires access to location data to enable the transfer of data to LED Badges via Bluetooth LE.")
builder.setMessage("Badge Magic collects location data to enable the transfer of data to LED Badges via Bluetooth LE in the background.")
builder.setCancelable(false)
builder.setPositiveButton("ACCEPT") { _, _ ->
activity.requestPermissions(locationPermissions, REQUEST_PERMISSION_CODE)
Expand Down

0 comments on commit a369194

Please sign in to comment.