Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates the language of the dialog and adds permission flags in the manifest #933

Merged
merged 1 commit into from
May 23, 2024

Conversation

AsCress
Copy link
Contributor

@AsCress AsCress commented May 23, 2024

Fixes #928
Updates the language of the disclosure dialog in accordance with Google's documentation.
Adds permission flags in the manifest to assert that the app never derives location from bluetooth.

Changes:

  • android/src/main/AndroidManifest.xml
  • android/src/main/java/org/fossasia/badgemagic/others/BadgeMagicPermission.kt

Screenshots for the change:

Screenshot_20240523_122412

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

@mariobehling mariobehling merged commit a369194 into fossasia:development May 23, 2024
1 check passed
@mariobehling
Copy link
Member

I have merged this in order to satisfy Google. Not sure if they accept it now. We are not using background actually.

@AsCress
Copy link
Contributor Author

AsCress commented May 23, 2024

I have merged this in order to satisfy Google. Not sure if they accept it now. We are not using background actually.

Yes. That's the reason I made the change, though we are not using it in background actually. However, I've added the required permission flag in the manifest. This should solve the upload problem for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add prominent disclosure in a dialog for location
2 participants