Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signup up button NOT responsive which is ovarlapping to workshop button (Bug SOLVED) #177

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Raunaksingh100
Copy link
Member

@Raunaksingh100 Raunaksingh100 commented Jul 5, 2020

  • Included a Preview link and screenshot showing after and before the changes.
  • Included a description of the change below.
  • Squashed the commits.

Changes done in this Pull Request

!-- If you fully fixed some issue, please insert the issue number after the #.
If you have not completely fixed an issue but only some part of it, then remove “Fixes #” and simply link the PR to the issue by writing '#' -->

Description / Changes--

In this i siolved two issued -

  1. social icons is overlapping (BUG) #179 issue fixed

  2. Signupfree Button ovarlapping with workshop Button  #176 issue fixed.

@chaitanya @mariobehling @liveHarshit
SIGNUPFREE button OVERLAPING with WORSHOP SCEHULDE BUTTON **this issue only need margin-bottom to give the distance **
and i also find that this bug is found in the different different screen width so i added a little bit more Media Queeery
so that the users cannot faced this problem .........

Screenshots if any:

Before:

signup and workshop overlapping 2019(foss)

After:

sign up solved issue 2019 foss 2019


@liveHarshit
@atm1504

@Raunaksingh100 Raunaksingh100 changed the title signup up button responsive which is ovarlapping to workshop button (Bug SOLVED) signup up button NOT responsive which is ovarlapping to workshop button (Bug SOLVED) Jul 5, 2020
.btn{
margin-bottom: 15px;

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the additional spaces everywhere.

Copy link
Member Author

@Raunaksingh100 Raunaksingh100 Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dishebh i removed the extra spaces review my File changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants