Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catchup #8

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Catchup #8

merged 5 commits into from
Sep 6, 2024

Commits on Sep 6, 2024

  1. testscript: use unix.CloneFile on MacOs 

    To fix unexpected errors of type:

```
[signal: killed]
FAIL: testscripts/myecho.txt:1: unexpected command failure
```

Fixes rogpeppe#200
    @bep @ldemailly
    bep authored and ldemailly committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    fd1755f View commit details
    Browse the repository at this point in the history

  2. CI: go back to macos-latest 

    Now that it seems we found a fix to rogpeppe#200, there is no reason to stick
to macos-11, which will likely be deprecated soon.

Update actions/setup-go to its latest version as well.
The new version uses caching by default, which we do not need.

While here, tidy up the cloneFile docs a bit.
    @mvdan @ldemailly
    mvdan authored and ldemailly committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    89b9345 View commit details
    Browse the repository at this point in the history

  3. internal: remove unused packages 

    internal/syscall/windows/registry was never imported by any of our
packages, so it seems to always have been unneeded module zip bloat.

internal/textutil was used by modfile, which now simply forwards to
x/mod/modfile, so the import is gone.
    @mvdan @ldemailly
    mvdan authored and ldemailly committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f01ffa4 View commit details
    Browse the repository at this point in the history

  4. all: remove some unused code 

    Primarily testscript's code to support calling testing.MainStart;
we originally needed that to implement our own deep code coverage,
but thankfully `go test` does that for us automatically now.
    @mvdan @ldemailly
    mvdan authored and ldemailly committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ed2767a View commit details
    Browse the repository at this point in the history

  5. files deleted in previous cherry-pick but not merged correctly

    @ldemailly
    ldemailly committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f95aaea View commit details
    Browse the repository at this point in the history