Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added slack tokens and pod name to get token index #24

Merged
merged 9 commits into from
Nov 7, 2023

Conversation

ani1311
Copy link
Collaborator

@ani1311 ani1311 commented Nov 7, 2023

This MR adds two features:

  • First is changing token to read a list of comma seperated slack tokens
  • Second is to use HOSTNAME to get pod name and then get pod index based on that and select a slack token key based on that index

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Files Coverage Δ
main.go 20.58% <55.26%> (+20.58%) ⬆️

📢 Thoughts on this report? Let us know!

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@ani1311 ani1311 requested a review from ldemailly November 7, 2023 22:08
main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main_test.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@ani1311 ani1311 merged commit 5dc7d1c into main Nov 7, 2023
6 checks passed
@ani1311 ani1311 deleted the pod-id-for-api-key branch November 7, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants