Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create build_image.sh #2

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Create build_image.sh #2

merged 1 commit into from
Aug 1, 2024

Conversation

Zenteno
Copy link

@Zenteno Zenteno commented Aug 1, 2024

This script allows to build and tag a docker image.
If the ECR url is provided, it will push the image to the ECR

If you want to push to ECR, you need to provide the AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY

This script will create and tag a docker image.
build_image.sh Show resolved Hide resolved
Copy link
Collaborator

@Taowyoo Taowyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question about envs

@Zenteno Zenteno changed the base branch from master to dev August 1, 2024 13:11
@Taowyoo Taowyoo self-requested a review August 1, 2024 13:37
@Taowyoo
Copy link
Collaborator

Taowyoo commented Aug 1, 2024

Since the lint error is not related I will ignore that and merge this PR.

@Taowyoo Taowyoo merged commit 80db46a into fortanix:dev Aug 1, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants