-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lndhub-go: integrate LndHub.go #519
base: master
Are you sure you want to change the base?
Conversation
Thanks, Pavol, lndhub seems low maintenance and a good fit for nix-bitcoin. If it supported clightning, I'd use it right away. Why do you set |
1bbfc45
to
644b632
Compare
CLN might be supported in the future, see getAlby/lndhub.go#123
Fixed in 644b632 |
a263052
to
edd9def
Compare
78ea328
to
875787f
Compare
Initial fixups to make the service run.
The best way to fix this is to make |
I've removed all app-specific settings and replaced them with option services.lndhub-go = {
settings = {
FEE_RESERVE = true;
MAX_SEND_AMOUNT = 1000000;
};
}; If you think some of these settings deserve a dedicated NixOS option, we can add them back in (maybe via a freeform module). |
Merged your fixups into my branch, thanks! Added bfceb1e which fixes the database name issue. |
Fixups.
We can add a password via the secrets mechanism, but I'd really prefer a socket connection. This should be simple to add to lndhub. |
Maybe it is enough to just change the connection string to |
Ah, great.
But manually connecting via |
Maybe we need to specify also the user?
|
No, this didn't help. Same with the equivalent |
I figured it out. First, this PR has to be merged: getAlby/lndhub.go#215 and then one can use the following connection string: |
When getAlby/lndhub.go#218 is merged, we can remove the |
Agreed! |
Rebased and squashed. Added fixup commits that need to wait until next release of LndHub.go is released, containing getAlby/lndhub.go#215 and getAlby/lndhub.go#218 |
lndhub-go 0.10.0 which contains the required fixes in getAlby/lndhub.go#215 and getAlby/lndhub.go#218 has been released and merged to nixpkgs via NixOS/nixpkgs#185649 |
Rebased after #537 has been merged. Removing draft status. |
0178abd
to
deeb21b
Compare
Pulled into the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK cff12ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applied to a03a0b7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 6a195f6
Dropped 6a195f6 since NixOS/nixpkgs#204769 has been merged and no longer required. Rebased ... |
LndHub.go is an accounting wrapper for the Lightning Network. It provides separate accounts for end-users and LndHub compatible API while written in Go.
upstream: https://github.com/getAlby/lndhub.go
This is a draft PR to gather feedback, also any help about how to test this is welcome!
Fixes #517