-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add automation for PR rejection #66
Conversation
@manish-singh-bisht is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
thanks a lot for working on this and sorry for the delay in review! Here is my feedback: 1. Lots of bot messages As you can see here in my test issue, the bot created 19 comments: Please make sure this doesn't happen.
I'm sorry if that wasn't clear from the ticket description, but we need this to work in PRs and not in Issues. So in the PR itself, I comment
This should also cut down a bit on the logic needed in the hook 🤓 Other than that, great work! Works very well :)) |
Please see Discord message, in my test repo it does not work.
Please make a video and explain how your fixes make it work as described in the comment 🙏 Thanks!! |
hey @jobenjada , removed the oss label checks for the pr,your pr didn't had ossgg labels so it didnt work , now it will. heres the updated video Screencast.from.15-04-24.07.03.08.PM.IST.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merging under the objection that I might reverse if the duplicate comment issue replicates on prod.
/award 250 |
Awarding manish-singh-bisht: 250 points! |
What does this PR do?
fixes #47
Technical description- since there is no persistent storage to store users whose pr is rejected , i am utilizing comment of GitHub. when /reject is executed for the first time a comment will be created "Attempted:user1". this comment is updated ,adding the new user ,every time the reject command is executed. this comment will be between the reject command and the rejection message. placement is important, as it makes it faster to catch this particular comment while looping through all the comment in the issue comment section when the assign command is executed by the user whose pr is already rejected,and is sure that this comment will be just above the first rejection message or just below the first reject command
Regex at multiple places be careful.
Screencast.from.12-04-24.02.42.00.AM.IST.webm
How should this be tested?
on an issue write /reject pr #prNumber message
Required
pnpm build
console.logs
git pull origin main
Appreciated