Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Responsive Design Issues for Improved Cross-Device Compatibility #64

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

nik132-eng
Copy link
Contributor

What does this PR do?

Make design mobile-friendly

Fixes #51


Before

image

image

image


After

image

image

image

image

How should this be tested?

  • use in mobile device

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at oss.gg
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 6, 2024

@nik132-eng is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Apr 6, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@nik132-eng
Copy link
Contributor Author

@mattinannt, One more page needs to be checked in responsiveness which is in the repository

image

in the local environment I filled out the dummy project but not immediately added. just asking in the future is that automated?

image

@nik132-eng
Copy link
Contributor Author

Issue tab


image

image

image

image

@nik132-eng nik132-eng changed the title Responsive design Fix Responsive Design Issues for Improved Cross-Device Compatibility Apr 8, 2024
@jobenjada
Copy link
Member

Hey @nik132-eng - thanks for your start.

This is quite a comprehensive issue giving 250 Points, so please make sure the complete app is properly responsive :)

Here are few points:

  1. Add a hamburger menu on mobile
image
  1. Headlines too big
image
  1. Add hamburger menu to dashboard. Right now it impossible to navigate:
image
  1. Reorganize the card content so its stacked on top of each other (flex-col)
image
  1. Decrease spacing between items:
    Uploading image.png…

Please go through all the screens and make sure the complete app is responsive :))

Thanks!!

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@nikdev10
Copy link

@jobenjada I made changes

@jobenjada jobenjada changed the title Fix Responsive Design Issues for Improved Cross-Device Compatibility fix: Responsive Design Issues for Improved Cross-Device Compatibility Apr 15, 2024
@jobenjada jobenjada added this pull request to the merge queue Apr 15, 2024
@jobenjada
Copy link
Member

/award 250

Copy link

oss-gg bot commented Apr 15, 2024

Awarding nik132-eng: 250 points!

Merged via the queue into formbricks:main with commit 0257d3f Apr 15, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make oss.gg fully responsive
3 participants