CHANGE: @W-17530186@: Update dependencies to latest where possible (#194

)
forcedotcom · Jan 21, 2025 · 2440010 · 2440010
1 parent d785d40
commit 2440010
Show file tree

Hide file tree

Showing 34 changed files with 1,083 additions and 1,175 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -22,12 +22,12 @@
   "devDependencies": {
     "cross-env": "^7.0.3",
     "jest": "^29.7.0",
-    "ts-jest": "29.2.3",
-    "rimraf": "*"
+    "rimraf": "*",
+    "ts-jest": "29.2.3"
   },
   "jest": {
     "testTimeout": 60000,
-    "coverageThreshold":  {
+    "coverageThreshold": {
       "global": {
         "branches": 80,
         "functions": 80,
@@ -43,4 +43,4 @@
       "!src/index.ts"
     ]
   }
-}
+}
diff --git a/packages/T-E-M-P-L-A-T-E/eslint.config.mjs b/packages/T-E-M-P-L-A-T-E/eslint.config.mjs
@@ -6,7 +6,11 @@ export default tseslint.config(
     ...tseslint.configs.recommended,
     {
         rules: {
-            "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }]
+            "@typescript-eslint/no-unused-vars": ["error", {
+                "argsIgnorePattern": "^_",
+                "varsIgnorePattern": "^_",
+                "caughtErrorsIgnorePattern": "^_"
+            }]
         }
     }
 );
diff --git a/packages/T-E-M-P-L-A-T-E/package.json b/packages/T-E-M-P-L-A-T-E/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@salesforce/t-e-m-p-l-a-t-e",
   "description": "T-E-M-P-L-A-T-E",
-  "version": "0.16.1-SNAPSHOT",
+  "version": "0.17.0-SNAPSHOT",
   "author": "The Salesforce Code Analyzer Team",
   "license": "BSD-3-Clause",
   "homepage": "https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview",
@@ -14,7 +14,7 @@
   "types": "dist/index.d.ts",
   "dependencies": {
     "@types/node": "^20.0.0",
-    "@salesforce/code-analyzer-engine-api": "0.16.1"
+    "@salesforce/code-analyzer-engine-api": "0.17.0-SNAPSHOT"
   },
   "devDependencies": {
     "@eslint/js": "^8.57.1",
@@ -23,8 +23,8 @@
     "jest": "^29.7.0",
     "rimraf": "*",
     "ts-jest": "29.2.3",
-    "typescript": "^5.7.2",
-    "typescript-eslint": "^7.8.0"
+    "typescript": "^5.7.3",
+    "typescript-eslint": "^8.20.0"
   },
   "engines": {
     "node": ">=20.0.0"

diff --git a/packages/code-analyzer-core/eslint.config.mjs b/packages/code-analyzer-core/eslint.config.mjs
@@ -8,7 +8,11 @@ export default tseslint.config(
     ...tseslint.configs.recommended,
     {
         rules: {
-            "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }]
+            "@typescript-eslint/no-unused-vars": ["error", {
+                "argsIgnorePattern": "^_",
+                "varsIgnorePattern": "^_",
+                "caughtErrorsIgnorePattern": "^_"
+            }]
         }
     }
 );
diff --git a/packages/code-analyzer-core/package.json b/packages/code-analyzer-core/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@salesforce/code-analyzer-core",
   "description": "Core Package for the Salesforce Code Analyzer",
-  "version": "0.21.0",
+  "version": "0.22.0-SNAPSHOT",
   "author": "The Salesforce Code Analyzer Team",
   "license": "BSD-3-Clause",
   "homepage": "https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview",
@@ -13,7 +13,7 @@
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "dependencies": {
-    "@salesforce/code-analyzer-engine-api": "0.16.1",
+    "@salesforce/code-analyzer-engine-api": "0.17.0-SNAPSHOT",
     "@types/js-yaml": "^4.0.9",
     "@types/node": "^20.0.0",
     "@types/sarif": "^2.1.7",
@@ -31,8 +31,8 @@
     "jest": "^29.7.0",
     "rimraf": "*",
     "ts-jest": "29.2.3",
-    "typescript": "^5.7.2",
-    "typescript-eslint": "^7.8.0"
+    "typescript": "^5.7.3",
+    "typescript-eslint": "^8.20.0"
   },
   "engines": {
     "node": ">=20.0.0"

diff --git a/packages/code-analyzer-core/src/code-analyzer.ts b/packages/code-analyzer-core/src/code-analyzer.ts
@@ -103,7 +103,7 @@ export class CodeAnalyzer {
         try {
             try {
                 resolvedModulePath = require.resolve(enginePluginModulePath, {paths: [this.config.getConfigRoot()]});
-            } catch (err) {
+            } catch (err) /* istanbul ignore next */ {
                 // On windows, there is an edge case where a standalone file in the same directory as the user's config
                 // file may not be resolved by require.resolve if given as just the file name. So we attempt to resolve
                 // this using path.resolve for this edge case.

diff --git a/packages/code-analyzer-core/src/results.ts b/packages/code-analyzer-core/src/results.ts
@@ -160,7 +160,8 @@ export class UnexpectedEngineErrorViolation implements Violation {
 
     getMessage(): string {
         return getMessage('UnexpectedEngineErrorViolationMessage', this.engineName,
-            this.error.stack ? this.error.stack : this.error.message); // Prefer to get the whole stack when possible
+            this.error.stack ? this.error.stack :  // Prefer to get the whole stack when possible
+                /* istanbul ignore next */ this.error.message);
     }
 
     getCodeLocations(): CodeLocation[] {

diff --git a/packages/code-analyzer-engine-api/eslint.config.mjs b/packages/code-analyzer-engine-api/eslint.config.mjs
@@ -8,7 +8,11 @@ export default tseslint.config(
   ...tseslint.configs.recommended,
     {
         rules: {
-            "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }]
+            "@typescript-eslint/no-unused-vars": ["error", {
+                "argsIgnorePattern": "^_",
+                "varsIgnorePattern": "^_",
+                "caughtErrorsIgnorePattern": "^_"
+            }]
         }
     }
 );
diff --git a/packages/code-analyzer-engine-api/package.json b/packages/code-analyzer-engine-api/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@salesforce/code-analyzer-engine-api",
   "description": "Engine API Package for the Salesforce Code Analyzer",
-  "version": "0.16.1",
+  "version": "0.17.0-SNAPSHOT",
   "author": "The Salesforce Code Analyzer Team",
   "license": "BSD-3-Clause",
   "homepage": "https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview",
@@ -24,8 +24,8 @@
     "jest": "^29.7.0",
     "rimraf": "*",
     "ts-jest": "29.2.3",
-    "typescript": "^5.7.2",
-    "typescript-eslint": "^7.8.0"
+    "typescript": "^5.7.3",
+    "typescript-eslint": "^8.20.0"
   },
   "engines": {
     "node": ">=20.0.0"

diff --git a/packages/code-analyzer-eslint-engine/eslint.config.mjs b/packages/code-analyzer-eslint-engine/eslint.config.mjs
@@ -6,7 +6,11 @@ export default tseslint.config(
     ...tseslint.configs.recommended,
     {
         rules: {
-            "@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }]
+            "@typescript-eslint/no-unused-vars": ["error", {
+                "argsIgnorePattern": "^_",
+                "varsIgnorePattern": "^_",
+                "caughtErrorsIgnorePattern": "^_"
+            }]
         }
     }
 );
diff --git a/packages/code-analyzer-eslint-engine/package.json b/packages/code-analyzer-eslint-engine/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@salesforce/code-analyzer-eslint-engine",
   "description": "Plugin package that adds 'eslint' as an engine into Salesforce Code Analyzer",
-  "version": "0.18.0",
+  "version": "0.19.0-SNAPSHOT",
   "author": "The Salesforce Code Analyzer Team",
   "license": "BSD-3-Clause",
   "homepage": "https://developer.salesforce.com/docs/platform/salesforce-code-analyzer/overview",
@@ -14,31 +14,31 @@
   "types": "dist/index.d.ts",
   "dependencies": {
     "@babel/core": "^7.26.0",
-    "@babel/eslint-parser": "^7.25.9",
+    "@babel/eslint-parser": "^7.26.5",
     "@eslint/js": "^8.57.1",
-    "@lwc/eslint-plugin-lwc": "^1.8.2",
+    "@lwc/eslint-plugin-lwc": "^1.9.0",
     "@lwc/eslint-plugin-lwc-platform": "^5.1.0",
-    "@salesforce/code-analyzer-engine-api": "0.16.1",
+    "@salesforce/code-analyzer-engine-api": "0.17.0-SNAPSHOT",
     "@salesforce/eslint-config-lwc": "^3.6.0",
     "@salesforce/eslint-plugin-lightning": "^1.0.0",
     "@types/eslint": "^8.56.10",
     "@types/node": "^20.0.0",
-    "@typescript-eslint/eslint-plugin": "^8.17.0",
-    "@typescript-eslint/parser": "^8.17.0",
+    "@typescript-eslint/eslint-plugin": "^8.20.0",
+    "@typescript-eslint/parser": "^8.20.0",
     "eslint": "^8.57.1",
     "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-jest": "^28.9.0"
+    "eslint-plugin-jest": "^28.11.0"
   },
   "devDependencies": {
     "@types/jest": "^29.5.14",
-    "@types/unzipper": "^0.10.9",
+    "@types/unzipper": "^0.10.10",
     "cross-env": "^7.0.3",
     "jest": "^29.7.0",
     "rimraf": "*",
     "ts-jest": "29.2.3",
-    "typescript": "^5.7.2",
-    "typescript-eslint": "^7.8.0",
-    "unzipper": "^0.10.9"
+    "typescript": "^5.7.3",
+    "typescript-eslint": "^8.20.0",
+    "unzipper": "^0.12.3"
   },
   "engines": {
     "node": ">=20.0.0"

diff --git a/packages/code-analyzer-eslint-engine/src/rule-mappings.ts b/packages/code-analyzer-eslint-engine/src/rule-mappings.ts
@@ -1101,6 +1101,10 @@ export const RULE_MAPPINGS: Record<string, {severity: SeverityLevel, tags: strin
         severity: SeverityLevel.Moderate,
         tags: [/* NOT RECOMMENDED */    COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.TYPESCRIPT]
     },
+    "@typescript-eslint/no-misused-spread": {
+        severity: SeverityLevel.High,
+        tags: [/* NOT RECOMMENDED */    COMMON_TAGS.CATEGORIES.ERROR_PRONE,    COMMON_TAGS.LANGUAGES.TYPESCRIPT]
+    },
     "@typescript-eslint/naming-convention": {
         severity: SeverityLevel.Moderate,
         tags: [/* NOT RECOMMENDED */    COMMON_TAGS.CATEGORIES.BEST_PRACTICES, COMMON_TAGS.LANGUAGES.TYPESCRIPT]