Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODINVSTOR-1277: Delete 6 unused instance database indexes #1101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MODINVSTOR-1277: Delete 6 unused instance database indexes #1101

wants to merge 1 commit into from

Conversation

julianladisch
Copy link
Contributor

Purpose

Delete the 6 biggest database indexes that are never used.

  • instance_identifiers_idx_gin
  • instance_identifiers_idx_ft
  • instance_title_idx
  • instance_contributors_idx
  • instance_indextitle_idx
  • instance_publication_idx

Approach

  • Delete 6 unused instance database indexes by marking them for deletion in schema.json
  • This autoamtically drops CQL array support for identifiers, therefore delete identifiers array unit tests
  • Delete PgUtil.getWithOptimizedSql code because the title index has been deleted
  • Delete populateRmbInternalIndex.sql because it runs for mod-inventory-storage <= 19.1.0

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

Related Issues

https://folio-org.atlassian.net/browse/MODINVSTOR-1277

@julianladisch
MODINVSTOR-1277: Delete 6 unused instance database indexes, drop CQL …
f81b4dc 
…array support for identifiers

https://folio-org.atlassian.net/browse/MODINVSTOR-1277

* Delete 6 unused instance database indexes:
  * instance_identifiers_idx_gin
  * instance_identifiers_idx_ft
  * instance_title_idx
  * instance_contributors_idx
  * instance_indextitle_idx
  * instance_publication_idx
* Drop CQL array support for identifiers, delete identifiers array unit tests
* Delete PgUtil.getWithOptimizedSql because the title index has been deleted
* Delete populateRmbInternalIndex.sql because it runs for mod-inventory-storage <= 19.1.0
@julianladisch julianladisch requested a review from a team as a code owner October 22, 2024 22:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmagin psmagin Awaiting requested review from psmagin psmagin is a code owner automatically assigned from folio-org/spitfire-backend

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@mukhiddin-yusuf mukhiddin-yusuf Awaiting requested review from mukhiddin-yusuf mukhiddin-yusuf is a code owner automatically assigned from folio-org/spitfire-backend

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julianladisch